perl::critic::policy::valuesandexpressions::prohibitcommaseparat(3) [centos man page]
Perl::Critic::Policy::ValuesAndExpressions::ProhibitCommUseraContriPerl::Critic::Policy::ValuesAndExpressions::ProhibitCommaSeparatedStatements(3) NAME
Perl::Critic::Policy::ValuesAndExpressions::ProhibitCommaSeparatedStatements - Don't use the comma operator as a statement separator. AFFILIATION
This Policy is part of the core Perl::Critic distribution. DESCRIPTION
Perl's comma statement separator has really low precedence, which leads to code that looks like it's using the comma list element separator not actually doing so. Conway suggests that the statement separator not be used in order to prevent this situation. The confusion that the statement separator causes is primarily due to the assignment operators having higher precedence. For example, trying to combine two arrays into another like this won't work: @x = @y, @z; because it is equivalent to @x = @y; @z; Conversely, there are the built-in functions, like "print", that normally force the rest of the statement into list context, but don't when called like a subroutine. This is not likely to produce what is intended: print join q{, }, 2, 3, 5, 7, ": the single-digit primes. "; The obvious fix is to add parentheses. Placing them like print join( q{, }, 2, 3, 5, 7 ), ": the single-digit primes. "; will work, but print ( join q{, }, 2, 3, 5, 7 ), ": the single-digit primes. "; will not, because it is equivalent to print( join q{, }, 2, 3, 5, 7 ); ": the single-digit primes. "; CONFIGURATION
This policy can be configured to allow the last statement in a "map" or "grep" block to be comma separated. This is done via the "allow_last_statement_to_be_comma_separated_in_map_and_grep" option like so: [ValuesAndExpressions::ProhibitCommaSeparatedStatements] allow_last_statement_to_be_comma_separated_in_map_and_grep = 1 With this option off (the default), the following code violates this policy. %hash = map {$_, 1} @list; With this option on, this statement is allowed. Even if this option is off, using a fat comma "=>" works, but that forces stringification on the first value, which may not be what you want. BUGS
Needs to check for "scalar( something, something )". AUTHOR
Elliot Shank "<perl@galumph.com>" COPYRIGHT
Copyright (c) 2007-2011 Elliot Shank. This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module. perl v5.16.3 Perl::Critic::Policy::ValuesAndExpressions::ProhibitCommaSeparatedStatements(3)
Check Out this Related Man Page
Perl::Critic::Policy::ValuesAndExpressions::ProhibitCompUsereContributed PerlPerl::Critic::Policy::ValuesAndExpressions::ProhibitComplexVersion(3) NAME
Perl::Critic::Policy::ValuesAndExpressions::ProhibitComplexVersion - Prohibit version values from outside the module. AFFILIATION
This Policy is part of the core Perl::Critic distribution. DESCRIPTION
One tempting way to keep a group of related modules at the same version number is to have all of them import the version number from a designated module. For example, module "Foo::Master" could be the version master for the "Foo" package, and all other modules could use its $VERSION by use Foo::Master; our $VERSION = $Foo::Master::VERSION; This turns out not to be a good idea, because all sorts of unintended things can happen - anything from unintended version number changes to denial-of-service attacks (since "Foo::Master" is executed by the 'use'). This policy examines statements that assign to $VERSION, and declares a violation under two circumstances: first, if that statement uses a fully-qualified symbol that did not originate in a package declared in the file; second if there is a "use" statement on the same line that makes the assignment. By default, an exception is made for "use version;" because of its recommendation by Perl Best Practices. See the "forbid_use_version" configuration variable if you do not want an exception made for "use version;". CONFIGURATION
The construction use version; our $VERSION = qv('1.2.3'); is exempt from this policy by default, because it is recommended by Perl Best Practices. Should you wish to identify "use version;" as a violation, add the following to your perlcriticrc file: [ValuesAndExpressions::ProhibitComplexVersion] forbid_use_version = 1 CAVEATS
This code assumes that the hallmark of a violation is a 'use' on the same line as the $VERSION assignment, because that is the way to have it seen by ExtUtils::MakeMaker->parse_version(). Other ways to get a version value from outside the module can be imagined, and this policy is currently oblivious to them. AUTHOR
Thomas R. Wyant, III wyant at cpan dot org COPYRIGHT
Copyright (c) 2009-2011 Tom Wyant. This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module. perl v5.16.3 2014-06-0Perl::Critic::Policy::ValuesAndExpressions::ProhibitComplexVersion(3)