Shell script help


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Shell script help
# 36  
Old 05-06-2010
I suggest adding a new for loop inside the existing for loop. The new loop structure will loop through the directories and for each directory it will loop through the file list.

I would avoid hard coding in the body of the function as much as possible because it becomes difficult to maintain.

Code:
# Variable section
DIR=( dir1 dir2 dir3 )
FILE=( fileName1 fileName2 fileName3 )

# Main section
for d in ${DIR[@]}; do
    for f in ${FILE[@]}; do
        processFile "${d}/${f}"
    done
done

So the full script looks like:
Code:
#!/bin/bash
NOW=$(date +"%Y-%m-%d")
LOGFILE=/tmp/myemail.txt

# List the directories and files to process. DO NOT INCLUDE THE TRAILING SLASHES IN THE DIRECTORIES.
DIR=( "10 hosts are listed here" )
FILE=( List file names here, without directories or slashes )

#############################
# Define functions
#############################

function checkStat
{
    # make sure stat command is installed
    which stat > /dev/null
    if [ $? -eq 1 ]; then
        echo "stat command not found!"
        exit 2
    fi
}

function processFile
{
    if [ -f ${1} ]; then
        VAR="$(stat -c %y ${1})"
        VAR2="${VAR:0:10}"

        if [ $NOW == $VAR2 ]; then
            echo "Current File Found: ${1}" | tee -a ${LOGFILE}
        else
            erroremail=1
            echo "Old File Found: ${1}" | tee -a ${LOGFILE}
        fi
    else
        erroremail=1
        echo "File Not Found: ${1}" | tee -a ${LOGFILE}
    fi
}

#############################
# Main
#############################

# Verify the stat command exists
checkStat

# Create or clear the log file
echo "" > ${LOGFILE}

# Process the files
for d in ${DIR[@]}; do
    for f in ${FILE[@]}; do
        processFile "${d}/${f}"
    done
done

#############
#Email Module
#############

if [ $erroremail -eq 1 ] ; then
       SUBJECT="ERROR: File Problem in Todays Check"
         else
              SUBJECT="OK: File Current"
fi

# Email To ?
EMAIL="somebody@nowhere.com"
# Email text/message
EMAILMESSAGE="/tmp/myemail.txt"
# send an email using /bin/mail
mail -s "$SUBJECT" "$EMAIL" < $EMAILMESSAGE

# 37  
Old 05-06-2010
That did work correctly. As a learning excercise, does:

Code:
processFile "${d}/${f}"

actually means: for directories in {d}, look for matching files in {f}? Now d and f are defined as files and directories in the above for loop. Would that be accurate statement?

I tried to modify the code, so that it shows each directory listing separate such as

*****
/dir1/
found files: /.../
found files: /../
*****
/dir2/
found files: /../
found files: /../
*****
and so on.

Like this, how ever the echo command is not working properly:

Code:
#!/bin/bash
NOW=$(date +"%Y-%m-%d")
LOGFILE=/tmp/myemail.txt

# List the directories and files to process. DO NOT INCLUDE THE TRAILING SLASHES IN THE DIRECTORIES.
DIR=( /dir1/location1 /dir2/location2 )
FILE=( mytest1*.txt mytest2.txt )

#############################
# Define functions
#############################

function checkStat
{
    # make sure stat command is installed
    which stat > /dev/null
    if [ $? -eq 1 ]; then
        echo "stat command not found!"
        exit 2
    fi
}

function processFile
{
    if [ -f ${1} ]; then
        VAR="$(stat -c %y ${1})"
        VAR2="${VAR:0:10}"

        if [ $NOW == $VAR2 ]; then
            echo "Current File Found: ${1}" | tee -a ${LOGFILE}
            echo "#################" | tee -a ${LOGFILE}
        else
            erroremail=1
            echo "Old File Found: ${1}" | tee -a ${LOGFILE}
            echo "#################" | tee -a ${LOGFILE}
        fi
    else
        erroremail=1
        echo "File Not Found: ${1}" | tee -a ${LOGFILE}
    fi
}

#############################
# Main
#############################

# Verify the stat command exists
checkStat

# Create or clear the log file
echo "" > ${LOGFILE}

# Process the files
for d in ${DIR[@]}; do
    for f in ${FILE[@]}; do
        processFile "${d}/${f}"
    done
done

#############
#Email Module
#############

if [ $erroremail -eq 1 ] ; then
       SUBJECT="ERROR: File Problem in Todays Check"
         else
              SUBJECT="OK: File Current"
fi

# Email To ?
EMAIL=someone@somewhere.com
# Email text/message
EMAILMESSAGE="/tmp/myemail.txt"
# send an email using /bin/mail
mail -s "$SUBJECT" "$EMAIL" < $EMAILMESSAGE

# 38  
Old 05-06-2010
processFile "${d}/${f}" is simply a function call while passing a single parameter. As the two nested loops (for d and for f) cycle through, the function is called multiple times with different parameters representing all possible combinations of directory and file name.

The reason your separator is not working is because the # symbol is being viewed as the beginning of a comment. Try a different character or try using single quotes.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Shell script newbie- how to generate service log from shell script

Hi, I am totally a newbie to any programming languages and I just started an entry level job in an IT company. One of my recent tasks is to create a script that is able to show the log file of linux service (i.e. ntpd service) lets say, if I run my script ./test.sh, the output should be... (3 Replies)
Discussion started by: xiaogeji
3 Replies

2. Shell Programming and Scripting

Pass C shell array to another C shell script(csh) and shell(sh)

Dear Friends, Please help me on this my script name is send.csh In this i have written the statement like this set args = ( city state country price ) I want to pass this array to another c shell called receiver.csh. and i want to use it in this c shell or how to pass to... (2 Replies)
Discussion started by: SA_Palani
2 Replies

3. Shell Programming and Scripting

How to write config shell script to pass variables in master shell script?

Dear Unix gurus, We have a config shell script file which has 30 variables which needs to be passed to master unix shell script that invokes oracle database sessions. So those 30 variables need to go through the database sessions (They are inputs) via a shell script. one of the variable name... (1 Reply)
Discussion started by: dba1981
1 Replies

4. UNIX for Dummies Questions & Answers

How to write Config shell script to pass variables in master shell script?

Dear Unix gurus, We have a config shell script file which has 30 variables which needs to be passed to master unix shell script that invokes oracle database sessions. So those 30 variables need to go through the database sessions (They are inputs) via a shell script. one of the variable name... (1 Reply)
Discussion started by: dba1981
1 Replies

5. Shell Programming and Scripting

Unable to pass shell script variable to awk command in same shell script

I have a shell script (.sh) and I want to pass a parameter value to the awk command but I am getting exception, please assist. diff=$1$2.diff id=$2 new=new_$diff echo "My id is $1" echo "I want to sync for user account $id" ##awk command I am using is as below cat $diff | awk... (2 Replies)
Discussion started by: Ashunayak
2 Replies

6. Shell Programming and Scripting

Correct shell script to Call One shell script from another shell script

Hi All, I have new for shell scripting. Problem : I have one scrip at serv1 and path of server is /apps/dev/provimage/scripts and script name:extract_ancillary.bat. I need to call this script at server2(my working server) and execute at server2 . Please let me know how to build the... (5 Replies)
Discussion started by: Vineeta Nigam
5 Replies

7. Shell Programming and Scripting

call another shell script and pass parameters to that shell script

Hi, I basically have 2 shell scripts. One is a shell script will get the variable value from the user. The variable is nothing but the IP of the remote system. Another shell script is a script that does the job of connecting to the remote system using ssh. This uses a expect utility in turn. ... (2 Replies)
Discussion started by: sunrexstar
2 Replies

8. Shell Programming and Scripting

How to use ssh execute other shell script on other host (shell script include nohup)?

i want use ssh on the host01 to execute autoexec.sh on the host02 like following : host01> ssh host02 autoexec.sh autoexec.sh include nohup command like follwing : nohup /home/jack/deletedata.sh & after i execute ssh host02 autoexec.sh one the host01. i can't found deletedata.sh... (1 Reply)
Discussion started by: orablue
1 Replies

9. Shell Programming and Scripting

invoking a shell script inside cgi shell script

Hi, I have an HTML form through which I get some text as input. i need to run a shell script say script.sh inside a perl-cgi script named main_cgi.sh on the form input. I want to write the contents of the form in a file and then perform some command line operations like grep, cat on the text... (2 Replies)
Discussion started by: smriti_shridhar
2 Replies

10. Shell Programming and Scripting

How to Run a shell script from Perl script in Parent shell?

Hi Perl/UNIX experts, I have a problem in running a shell script from my perl script (auto.pl). I run the perl script using perl auto.pl from the shell prompt The shell script picks the files in "input" folder and procesess it. The shell script blue.sh has this code. export... (16 Replies)
Discussion started by: hifake
16 Replies
Login or Register to Ask a Question